RD_subs conversion not correct

ruud
ruud
Offline
0
Hi,
One of my users just did it's first conversion of a rd-subs subscription.
Issue is that although the amount involved is 60,- excl. VAT, Affiliate Tracker registered the conversions as 0,-
See screenshot.

Not sure if this could be related, but the sale made was for the same user as the affiliate (the affiliate was logged in when buying the subscription).

Accepted Answer

Robert
Robert
Offline
Thursday, November 09 2017, 09:10 AM - #Permalink
0
The RD-Subs plugin was not working because of the Constant DS which is not loaded in Joomla! anymore. Because of this missing contstant the scripts throws a Fatal Error.

I have now included the DS constant in the plugin but it would be awesome/better to add this to the components/com_affiliatetracker/helpers/helpers.php class.

@Ruud; Updating to the latest version will solve the issue.
The reply is currently minimized Show
Responses (6)
  • Accepted Answer

    Robert
    Robert
    Offline
    Thursday, November 09 2017, 09:40 AM - #Permalink
    0
    The code is working properly and I think there is nothing to worry about. All developers may choose to use a DS constant but then the component should handle it also when including only one class in my opinion. The DS constant should be added in the class so other developers who don't want the DS in their code are not being forced to have that piece of code inside the plugin.
    The reply is currently minimized Show
  • Accepted Answer

    ruud
    ruud
    Offline
    Thursday, November 09 2017, 09:20 AM - #Permalink
    0
    Robert wrote:

    The RD-Subs plugin was not working because of the Constant DS which is not loaded in Joomla! anymore. Because of this missing contstant the scripts throws a Fatal Error.

    I have now included the DS constant in the plugin but it would be awesome/better to add this to the components/com_affiliatetracker/helpers/helpers.php class.

    @Ruud; Updating to the latest version will solve the issue.


    Top Support Robert! Good that you look further then only your own code. This solved the issue for me, but leaves me worried (a lot) about the support and code quality of the Affiliate Tracker extension. As I learned the constant DS is a left over from Joomla 1.5 and earlier...
    • Germinal Camps
      more than a month ago
      hi

      I think you're confused... in affiliate tracker the DS constant is always defined and therefore it works just fine..!

      the problem was strictly inside the RD plugin, because (as I read on from Robert's post) it was using DS constant without defining it first. Nothing to do with affiliate tracker at all.
      So, not sure why you would be worried about affiliate tracker, if the problem was NOT on affiliate tracker.

      do you understand?

      I had no way of knowing what the error was because I don't have that plugin, it's not ours...
    The reply is currently minimized Show
  • Accepted Answer

    ruud
    ruud
    Offline
    Wednesday, November 08 2017, 10:09 AM - #Permalink
    0
    Germinal Camps wrote:

    yes, the purchase will be handled as a conversion with commission in that case.


    Would be a good Feature if you could configure NOT to handle commision for own purchases: for those who subscribe to your Affiliate program just to receive additional 'discount'.
    • Germinal Camps
      more than a month ago
      certainly we will consider it. thanks!
    The reply is currently minimized Show
  • Accepted Answer

    Tuesday, November 07 2017, 06:11 PM - #Permalink
    0
    yes, the purchase will be handled as a conversion with commission in that case.
    The reply is currently minimized Show
  • Accepted Answer

    ruud
    ruud
    Offline
    Tuesday, November 07 2017, 09:45 AM - #Permalink
    0
    Hi, why didn't I think of that answer when posting this: http://www.joomlathat.com/support/affiliate-tracker/wrong-backdrop-for-terms-and-conditions-modal#reply-37454

    anyway.

    still open is the second (not rd-subscription related):
    "Not sure if this could be related, but the sale made was for the same user as the affiliate (the affiliate was logged in when buying the subscription)."

    When an affiliate is logged in and does a purchase, will that purchase be handled as a conversion with commission?
    The reply is currently minimized Show
  • Accepted Answer

    Monday, November 06 2017, 01:21 PM - #Permalink
    0
    Hello,

    RD-subs is not one of our plugins. You should ask the developers of that plugin, probably there's something wrong in its code..
    The reply is currently minimized Show
Your Reply