Number of issues with music collection

0
Hi

I've just bought and installed the community professional version of this plugin and I've got a number of issues. (aside from various layout and css issues I'm going to have to fix to make it fit the site).

I've ordered them most important to least important.

You can see the site at www.rebeccasaforia.com, the plugin is under 'mixes'.

CRITICAL * If I attempt to download a file in an album, I get a 404 error. The link it sends me to, for example, is http://www.rebeccasaforia.com/index.php?option=com_muscol&view=file&format=raw&id=2&Itemid=58 - I'm wondering if this 404 is linked to the player's inability to function.

CRITICAL * The player does not work. I've got it to appear on the musiccol pages after enabling the plugin in joomla, but it comes up with 0:00 playtime indicated on the album page and does nothing when you press play. When you drill down to an individual song it displays 'correct' playtime of 60:00 but that's clearly just been pulled from the content in the database about the song as, again, when pressing play, nothing happens.

IMPORTANT * The artist photo and album artwork photos seem to display at 300x300px when you are viewing either an artist or a single album respectively even though I can see no setting that defines this. Can this option be added to preferences?

ADMIN - BUG - ANNOYANCE * When adding an album using the scan function, the save button no longer renders on the joomla function toolbar where it should be - it appears in the middle of the admin page content area above the form.

ADMIN - BUG - ANNOYANCE * I see a thread elsewhere where one of the issues I have is discussed - the errors when scanning a specific folder in the quick add album functions - but you claim that it does not affect Linux hosting environments - this is untrue, as I am hosting on Linux and am getting the same errors. I work around by simply scanning the docroot and navigating through the folders, but it still needs to be fixed.

Any advice would be appreciated. If you need further details please let me know.

Thanks

Rebecca
Responses (12)
  • Accepted Answer

    Sunday, March 07 2010, 07:27 PM - #Permalink
    0
    RE: The download bug; I have 'fixed' this by changing line 53 in components/com_muscol/views/file/view.raw.php from:

    else $filePath = JPath::clean( JPATH_SITE.DS.$dirname.DS.$fileName );

    to

    else $filePath = JPath::clean( JPATH_SITE.DS.$fileName );

    as a quick workaround. $dirname was causing 'songs' to appear twice in the filepath, so downloads were looking for $docroot/songs/songs/albumfolder/song.mp3

    This has not, sadly, fixed the player issue which I'm trying to work out now.
    The reply is currently minimized Show
  • Accepted Answer

    Sunday, March 07 2010, 07:33 PM - #Permalink
    0
    Having tailed the access log while pressing play on the player it's become clear that the $dirname is also unnecessarily injected into the filepath for the player.

    It would appear that the $dirname variable is not being used as the directory base when files are added, but the docroot is. This means that when dirname is added on again, it causes it to be double listed.

    knowing that, I attempted to clear the song folder config variable in parameters, but if I left the field blank it filled it out with /songs again. If I attempted to save / the setting was saved, but the player is still trying to load from /songs/songs/.

    I've worked around this by changing components/com_muscol/helpers/helpers.php 's getSongFileURL function by changing

    $song_base = $base_path . $dirname ;

    to

    $song_base = $base_path ;

    As an aside, why isn't this helper used by view.raw to get the URL of the file?
    The reply is currently minimized Show
  • Accepted Answer

    Sunday, March 07 2010, 09:01 PM - #Permalink
    0
    This is very weird because I've not encountered this problem in my installation.

    For your question about why view.raw.php doesn't use getSongFileURL, when you create a header link for downloading file, you need absolution/relative path to the file but not an http URL. JPATH_SITE... gives you the path to file but getSongFileURL returns a URL. That's why view.raw.php doesn't use that particular function.
    The reply is currently minimized Show
  • Accepted Answer

    Sunday, March 07 2010, 09:13 PM - #Permalink
    0
    BUG?: params->show_add_to_playlist does not appear to be anywhere in the parameter editor in the administration interface?
    The reply is currently minimized Show
  • Accepted Answer

    Sunday, March 07 2010, 09:15 PM - #Permalink
    0
    gomakeit wrote:
    This is very weird because I've not encountered this problem in my installation.

    For your question about why view.raw.php doesn't use getSongFileURL, when you create a header link for downloading file, you need absolution/relative path to the file but not an http URL. JPATH_SITE... gives you the path to file but getSongFileURL returns a URL. That's why view.raw.php doesn't use that particular function.


    You're right - my bad. I didn't even think about the fact that view.raw was referencing the filesystem path, not the URL. Doh.

    As for the problem with the $dirname - are you using quickadd or uploading directly in the add-album interface? I've noticed that my add-album uploads obey the path variable - suspect this is a problem relating to quick-added albums. I detest http-post-uploads so I'll always be FTPing up in advance so this is always going to affect me.
    The reply is currently minimized Show
  • Accepted Answer

    Sunday, March 07 2010, 09:50 PM - #Permalink
    0
    hello saforia

    well, I've not readed everything ;) but just a quick though:
    you should change ANY of that code you changed. if the problem was that the "songs" fodler appeared twice, then it means that you wrote it twice on your parameters:

    probably one on the "songs path" parameter, and another on the "songs server" parameter.

    the SONGS SERVER should be EMPTY (the point is: the default parameters amke the component work, thats for sure. and that parameter is empty by default, and should be empty...so.. leave it that way!)

    tell me if that makes sense. I REALLY suggest you to undo these changes you made on the "$dirname" codes and so.

    please let me know if that helps. when we get this through, we'll check these other issues you have, I'm pretty sure we'll be able to solve them quickly as well :)

    best,
    Germi
    The reply is currently minimized Show
  • Accepted Answer

    Sunday, March 07 2010, 09:59 PM - #Permalink
    0
    Hi germi

    Songs server was blank.
    Songs path was prepopulated with /songs from the outset. (ie they were at the defaults)

    Only thing I can think of - do you have to really enter the preferences page and save it just to get the defaults properly stored in the component before using the system? If so, this could be considered buggy behaviour as these settings could be written as part of the setup script in the component package. Nonetheless songs that have been added since the php changes were made and the settings have been saved and altered still work, so $dirname would still be causing problems if I hadn't changed the php, if that makes sense.

    The problem *possibly* only affects songs added using quickadd for already uploaded files.
    The reply is currently minimized Show
  • Accepted Answer

    Sunday, March 07 2010, 10:05 PM - #Permalink
    0
    hmm.... but still makes no much sense this "double" songs on the path...

    I've been on your site and played a song (http://www.rebeccasaforia.com/index.php?option=com_muscol&view=song&id=7&Itemid=58) and it played fine.

    can you point me to somewhere where the song does not play?

    PS:I'm going to bed now so I think we'll have to end this conversation tomorrow! ;)

    PPS: I see you're a DJ! :) nice! are you in London?
    The reply is currently minimized Show
  • Accepted Answer

    Sunday, March 07 2010, 10:05 PM - #Permalink
    0
    Also, can you tell me where I can find the sql query that pulls the list of albums for an artist as I want to reverse the order they display in (I want newest first, not last, and the only place I seem to be able to control that is for search results, not an artist page).
    The reply is currently minimized Show
  • Accepted Answer

    Sunday, March 07 2010, 10:07 PM - #Permalink
    0
    components/com_muscol/models/artist.php line 211:

    ' ORDER BY year,month ';

    change it for

    ' ORDER BY year DESC,month DESC ';
    The reply is currently minimized Show
  • Accepted Answer

    Sunday, March 07 2010, 10:08 PM - #Permalink
    0
    germi wrote:
    hmm.... but still makes no much sense this "double" songs on the path...

    I've been on your site and played a song (http://www.rebeccasaforia.com/index.php?option=com_muscol&view=song&id=7&Itemid=58) and it played fine.

    can you point me to somewhere where the song does not play?


    The system works now because I've made the changes I was talking about - if I restore the files then all of the files will cease to function (except maybe the Ananda EP sample clips which were http-uploaded in the admin interface).


    PS:I'm going to bed now so I think we'll have to end this conversation tomorrow! ;)

    PPS: I see you're a DJ! :) nice! are you in London?


    I'm not actually the site owner though I write on her behalf, yeah, she's a DJ and producer in London. I'm just her flatmate/website lackey :p
    The reply is currently minimized Show
  • Accepted Answer

    Sunday, March 07 2010, 10:09 PM - #Permalink
    0
    germi wrote:
    components/com_muscol/models/artist.php line 211:

    ' ORDER BY year,month ';

    change it for

    ' ORDER BY year DESC,month DESC ';


    Thanks for that!
    The reply is currently minimized Show
Your Reply