Keyword bug

0
I found a new bug involving keywords with non-latin UTF8 characters. I looked at the database structure and it seems to me that there should be two different keyword fields for these two tables:
1. jos_muscol_albums
2. jos_muscol_artists

MC by default fill out these fields using the following rules:
1. album name + artist name
2. artist name

As far as I understand, this is to facilitate the search function. However if either the album name or the artist name has non-latin UTF8 characters, the keyword is not inserted into the tables. This create trouble when searching for these non-latin albums/artists. I haven't found a way to solve this yet. Do you have any idea Germi?
Responses (17)
  • Accepted Answer

    Friday, March 19 2010, 04:22 AM - #Permalink
    0
    Where can I find the SQL command to insert keywords? I think this is the place to look...
    The reply is currently minimized Show
  • Accepted Answer

    Friday, March 19 2010, 12:59 PM - #Permalink
    0
    administrator/components/com_muscol/tables/album.php

    and artist.php

    on this two files, the keywords are "generated" from the album or artist name, and saved into the database.

    maybe this "keyword generation" process gives some problem on non-latin characters... :S
    The reply is currently minimized Show
  • Accepted Answer

    Friday, March 19 2010, 06:26 PM - #Permalink
    0
    OK I found the problem. It has to do with the get_keywords function in the files you mentioned. The call to JFilterOutput::stringURLSafe seems to mess up the encoding of the characters and they're therefore not added into the database. It looks to me that the strtolower function of JFilterOutput::stringURLSafe causes the problem.

    If I take out the cal to JFilterOutput, the keywords are generated correctly. However would there be any security concern when doing so?

    Thanks again Germi :)
    The reply is currently minimized Show
  • Accepted Answer

    Friday, March 19 2010, 06:34 PM - #Permalink
    0
    well, that JFilterOutput::stringURLSafe was precisely putted there to avoid strange characters: I didnt think in Chinese when I wrote it (never though that Music Collection would be used in Chinese! :) )

    but nothing you have to worry about security (I mean, HTML entities, for example, or MySQL injections, are striped before that)
    The reply is currently minimized Show
  • Accepted Answer

    Friday, March 19 2010, 07:34 PM - #Permalink
    0
    lol yea I might be the rare one here but hey the broader your audience are the better right? I've been caught up with something at work, I'll make sure to clean up my code and send you the modification involving getID3 library
    The reply is currently minimized Show
  • Accepted Answer

    marcap
    marcap
    Offline
    Friday, August 09 2013, 09:20 AM - #Permalink
    0
    Hello Girmi,
    The letter "&" in the generated keyword became an "a" so it will be a problem to find album or artist that have a "&" in thei titles or names.
    The reply is currently minimized Show
  • Accepted Answer

    marcap
    marcap
    Offline
    Friday, August 09 2013, 09:26 AM - #Permalink
    0
    LOL!! It says again that I am not a verified customer! but I'm using the good one.
    The reply is currently minimized Show
  • Accepted Answer

    Friday, August 09 2013, 12:14 PM - #Permalink
    0
    hello!

    well the "&" are not counted on the keywords, they are removed..

    it says you're not verified because your latest subscription expired on June 14th I believe ;)
    The reply is currently minimized Show
  • Accepted Answer

    marcap
    marcap
    Offline
    Friday, August 09 2013, 02:43 PM - #Permalink
    0
    Thank you for your replay.

    Is there a way to put the "&" again in the keywords? Because I need it and it is strange that it was removed.

    The other day when I wrote something in the forum "marcap" was recognize. Anyway, it is not a problem.
    The reply is currently minimized Show
  • Accepted Answer

    Friday, August 09 2013, 04:06 PM - #Permalink
    0
    "marcap" subscription expired actually long ago.. 14 june 2012! I think you're confused.

    to allow "&" in the keywords a little code removal is necessary...
    The reply is currently minimized Show
  • Accepted Answer

    marcap
    marcap
    Offline
    Friday, August 09 2013, 04:20 PM - #Permalink
    0
    I know that my subscription expired long time ago but just a few days ago I asked you how come I had a lot of errors installing the component.
    As "marcap" it appeared "this is a verified customer".
    Anyway it is not important.
    Important is that you took off the "&" from the code (who knows why) and for sure you are not going to say what to do.
    The reply is currently minimized Show
  • Accepted Answer

    Friday, August 09 2013, 04:28 PM - #Permalink
    0
    hello

    I'm sorry to say but you're confused :) when you asked me a few days ago the user appeared as "not verified". actually I told you this!
    please read the conversation: http://www.joomlathat.com/support/music-collection/joomla-2-5/problem-installing-in-localhost

    you're probably confused, you saw MY status which is "verified" and you though it was yours ;) but yours did not show as verified at all ;) that's why I told you. the subscription expired more than 1 year ago, it's simply not possible

    I never took "&" from the code, it has ALWAYS been removed, from version 1.0.0

    my friend, please try to be reasonable here, you're mistaken in 2 things! :)
    The reply is currently minimized Show
  • Accepted Answer

    Friday, August 09 2013, 04:31 PM - #Permalink
    0
    here is a screenshot of our conversation, I think you saw my status "verified" (green) and you thought it was yours (red)
    The reply is currently minimized Show
  • Accepted Answer

    marcap
    marcap
    Offline
    Friday, August 09 2013, 07:46 PM - #Permalink
    0
    I did not made a mistake with you "green", I just, probably, thought that using "marcap" it was going to be "verified" even if my subscription was over.

    About the "&": I didn't realize about it before because I was not using names of groups or album or whatever with that letter in it.
    Very strange that it was never there.
    The reply is currently minimized Show
  • Accepted Answer

    marcap
    marcap
    Offline
    Saturday, August 10 2013, 10:20 AM - #Permalink
    0
    Hello Girmi,
    Is it possible to know in which file I can look for some code to remove then I try to do it alone?
    Thank you.
    The reply is currently minimized Show
  • Accepted Answer

    Saturday, August 10 2013, 10:25 AM - #Permalink
    0
    Hello,

    basically there's a function (well, a set of functions) on the file administrator/components/com_muscol/tables/album.php that "removes" all the special characters from the keywords field (like "&" and others), you need to get ride of that basically.

    there you go.. free support..! ;) please from now on consider renewing

    best,
    Germi
    The reply is currently minimized Show
  • Accepted Answer

    marcap
    marcap
    Offline
    Saturday, August 10 2013, 12:05 PM - #Permalink
    0
    Thank you for your answer, anyway the solution was here and it helped me a lot.

    http://www.joomlathat.com/support/music-collection/pre-buy-questions/greek-and-english-in-the-alphabet-search#reply-11836
    The reply is currently minimized Show
Your Reply